Remove int256 operator<< test for showbase with 0 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upsteam libc++ is now also showing the octal `0` and hex `0x` prefixes with zero, see llvm/llvm-project#120859 These tests were failing with upstream libc++. The previous three lines test this enough; just remove the tests that now have inconsistent output across C++ standard libraries.
Contributor
Author
|
(We ran into these tests failing in Chromium during a libc++ update.) |
kwlyeo
approved these changes
Mar 12, 2025
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upsteam libc++ is now also showing the octal
0and hex0xprefixes with zero, seellvm/llvm-project#120859
These tests were failing with upstream libc++. The previous three lines test this enough; just remove the tests that now have inconsistent output across C++ standard libraries.